Add send_future to ComponentLink #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upgrade wasm-bindgen to 0.2.51 * Run macro tests on beta and update readme * Update README.md * Update .travis.yml
jstarry
requested changes
Nov 10, 2019
There was a problem hiding this comment.
Looks awesome! Really great to have futures support finally! Thanks @hgzimmerman !!
jstarry
approved these changes
Nov 11, 2019
llebout
pushed a commit
to llebout/yew
that referenced
this pull request
Jan 20, 2020
* bump wasm-bindgen to 0.2.51 (yewstack#681) * upgrade wasm-bindgen to 0.2.51 * Run macro tests on beta and update readme * Update README.md * Update .travis.yml * implement send_future * cargo fmt * add todo question * static dispatch on Error in future * Add framework for example using futures * add a basic future to indicate that futures work * change example to fetch markdown instead of just resolving a string * remove unnneded import * Force users to handle errors in their future * Force users to handle errors in their future * cleanup and introduction of FetchState * respond to feedback * update comment * fix cargo.toml dependency issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #686
Based on prior work in plaster.
This PR aims to add limited Futures support to Yew by way of registering futures that will send messages to component event loops when they complete.
Edit: The provided example code demonstrates a working version of using futures to make fetch requests using faculties exposed by web_sys.