AnalyticsSDK: Add new optional scope Event Payload field for pages #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AjayBenno
previously approved these changes
Feb 20, 2024
| @@ -111,6 +111,8 @@ export interface EventPayload { | |||
| sessionId?: string | null; | |||
| /** Fields specific to reporting Yext Pages Analytics Events */ | |||
| pages?: { | |||
| /** The scope of an action. Applies to Pages events. */ | |||
There was a problem hiding this comment.
Are we holding off adding tests using this until we implement the backend?
There was a problem hiding this comment.
That's what I was thinking, but do you think we can go ahead and add tests?
AjayBenno
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CR creates a new optional string field that denotes the scope of pages actions in event payloads.
J=FUS-6253
TEST=none