EventsSDK: Release Candidate v1.0.0-beta.1 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the initial beta release we did not include custom actions as a part of the Action type. This change adds support for an action field that starts with 'c_' or 'C_'. This also updates some comments and documentation. J=FUS-5894 R=abenno, hyu TEST=auto Updated existing tests to use a custom action. Ran npm run test after building and all pass. Change-Id: I383636e369cb0fad5d69ce21affde36cfb9f27f4
Make a few small fixes to the readme. - lowercase a in analytics inport - no new when invoking - remove appendix - add missing coma J=FUS-5897 R=abenno, mtian TEST=none Change-Id: I267ac68898641168fb4037a80fd3f146ffcf7030
Remove errors from EventApiResponse. Instead we will report errors by calling Promise.reject() which will print out the errors from the events api. If it is successful, we return (but do not print) the result json with the event id if called from fetch, and a boolean as a string if called from post. J=FUS-5895 R=mtian, abenno TEST=manual Made valid and invalid requests to the test site and ensured expected behavior. Change-Id: I1ecd6aa628c113b93c0ba7b10837133c9e53af5a
Change-Id: I5a968393338025e081d1c6a79e233579980e445a
Rebase on Main
EventsSDK: Support Custom Actions in EventPayload
EventsSdk: Update ReadMe
Change-Id: I3848b4775dc6e86cdf539430febc4af7df4d5520
Change-Id: Ie1d27a6b5d3ff82b2394e9ce7c158930bc8dc9dd
* Remove unused pacakge dependencies * Re-add fetch-mock-jest as a dependency
Change-Id: Id53cbe40a336c204454f520df99e5ac741925a99
EventsSdk: Update report return type
Adding test coverage up to 100% for report file
* Set playwright GH action * npm run test runs all tests and test workflow only runs unit tests
EventsSDK: Add new CDN Actions
UnifedSDK: add more tests for report
Use Commit Hook to Auto Format Code
Add search object field to EventPayload. Add doc comments for auto generated documentation. J=FUS-5913 R=mtian, abenno, hyu TEST=manual Updated test site to have button for sending search event.
Format the Whole Codebase
Fix Husky Setup
Update queryId and searchId params in Test Site to match expected pattern. R=mtian, hyu TEST=manual Ran test site and there was a successful response for the Send Search Event buttonEventsSDK: Update Search Params in Test Site Co-authored-by: Ethan Jaffee <ejaffee@yext.com>
Add playwright tests to serve as acceptance tests for this SDK. They will run the test site and click the buttons on three browsers, Chromium, Firefox, and Webkit and check for a 202 response. They can be run with the other unit tests using npm run test, or on their own with npx playwright test. The browsers can also be viewed live as they execute by using npx playwright test --headed. J=FUS-5909 R=mtian, sawong, abenno TEST=auto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Candidate for version v1.0.0-beta.1 of the Yext Analytics Events SDK.