Skip to content

Commit

Permalink
Revert 'Fix google maps InvalidValueError in theme' (#981)
Browse files Browse the repository at this point in the history
Reverts  #955 because the necessary corresponding [PR in the SDK](yext/answers-search-ui#1548) didn't make it into v1.11

J=none
TEST=manual

Build the test site with the new v1.11 SDK and see that the icons now look correct
  • Loading branch information
cea2aj committed Oct 13, 2021
1 parent dd89e78 commit 0e31bd3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion templates/universal-standard/script/map-pin.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
if (mapProvider === 'google') {
config.svg = svg;
{{!-- Don't use the sdk's built-in label for GoogleMapProvider --}}
config.label = '';
config.label = {};
config.scaledSize = {
w: pinStyling.width,
h: pinStyling.height,
Expand Down
2 changes: 1 addition & 1 deletion templates/vertical-map/script/map-pin.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
if (mapProvider === 'google') {
config.svg = svg;
{{!-- Don't use the sdk's built-in label for GoogleMapProvider --}}
config.label = '';
config.label = {};
config.scaledSize = {
w: pinStyling.width,
h: pinStyling.height,
Expand Down

0 comments on commit 0e31bd3

Please sign in to comment.