Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix google maps InvalidValueError in theme #955

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Conversation

yen-tt
Copy link
Contributor

@yen-tt yen-tt commented Sep 15, 2021

  • SDK GoogleMapMarkerConfig expects label to be of type string

J=SLAP-655
TEST=manual

see that map is working properly and error is gone in browser inspector

- SDK GoogleMapMarkerConfig expects label to be of type string

J=SLAP-655
TEST=manual

see that map is working properly and error is gone in browser inspector
@coveralls
Copy link

Coverage Status

Coverage remained the same at 8.61% when pulling d6d9ae3 on dev/google-map-error into 35bfa38 on develop.

@yen-tt yen-tt merged commit b80ba4c into develop Sep 16, 2021
@yen-tt yen-tt deleted the dev/google-map-error branch September 16, 2021 12:37
cea2aj added a commit that referenced this pull request Oct 13, 2021
Reverts  #955 because the necessary corresponding [PR in the SDK](yext/answers-search-ui#1548) didn't make it into v1.11

J=none
TEST=manual

Build the test site with the new v1.11 SDK and see that the icons now look correct
@cea2aj cea2aj mentioned this pull request Nov 16, 2021
nmanu1 added a commit that referenced this pull request Nov 16, 2021
## Version 1.26.0
### Features
- Add support for the auth token, with a new global_config `token` field  (#976)
- Add support for the visitor, which can be set or changed at runtime (#970)
- Add support for generic thumbs up/down feedback buttons to all cards (#973, #1005)
- Handle page and template names with spaces (#988)

### Changes
- Update styling of navigation ‘More’ menu (#989)
- Update hover color of search bar buttons (#1000)
- Internal repo changes (automate WCAG testing (#987))

### Bugfixes
- Fix console error which would appear on google maps (#955)
- Fix extra query when loading in iframe integrations (#986)
- Fix bug that displayed links that didn’t exist (#990)
- Allow microphone access for voice search in iframe (#991)
- Fix issue with custom search icon size (#992)
- Fix bug with new prop comments not being added (#1004)
- Fix distance alignment on location cards (#1006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants