Remove styling to allow switching answers-search-ui icon divs to spans #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmcginnis
approved these changes
Feb 20, 2024
Merged
nmanu1
added a commit
that referenced
this pull request
Feb 20, 2024
### Fixes - Resolve vulnerabilities (#1167) - Remove `span` styling and bump answers-search-ui version to 1.17 so icon `div`s are changed to `span`s without affecting their styling (#1169, #1170) - Note, any custom styling that is applied by targeting `div`s or `span`s directly may be impacted by this change. This could result in previously applied styles no longer being applied to these icons, or other styles inadvertently being applied to the icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes styling that targets arbitrary
spans inAnswers-resultsHeader. This styling was being automatically applied to icons using the answers-search-ui partial (or other icons) when thedivs were changed tospans for accessibility reasons, which caused visual regressions. This was only an issue on vertical full page map templates which include the search bar and nav tabs inAnswers-resultsHeader, instead of just the results count and applied filters.Based on the PR that initially added this styling, this was needed to ensure results count elements had the correct ordering on both ltr and rtl experiences. I checked a vertical template and vertical full page map template for
enandarlocales in the test site and the results count elements seem to still be flipped, as expected. The only otherspans that I saw withinAnswers-resultsHeaderseemed to be the nav More icon and applied filters, both of which seemed fine after removing this styling.J=TECHOPS-11042
TEST=manual
Since we no longer have a paid Percy subscription, our snapshots are not being generated. So I've included some screenshots of pages after the changes in this PR, pointing to v1.16.6 of answers-search-ui which contains the icon
divtospanchange:en:
ar:
