Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.33.5 #1171

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Version 1.33.5 #1171

merged 4 commits into from
Feb 20, 2024

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Feb 20, 2024

Fixes

EmilyZhang777 and others added 4 commits February 13, 2024 11:14
This PR resolves the following vulnerabilities:
- upgrade `webpack` to version 5.90.1 to resolve vulnerability to Improper Access Control in versions lower than 5.76.0
- upgrade `http-cache-semantics` to version 4.1.1 to resolve vulnerability to Inefficient Regular Expression Complexity in versions lower than 4.1.1
- upgrade `get-func-name` to version 2.0.2 to resolve vulnerability to Uncontrolled Resource Consumption / Inefficient Regular Expression Complexity in versions lower than 2.0.1
- remove insecure document methods

J=VULN-37755 - VULN-37760, VULN-38372, VULN-38400, VULN-38433

---------

Co-authored-by: Liah Kim <likim@yext.com>
Co-authored-by: Nidhi Manu <nmanu@yext.com>
*An automated PR which updates the version number in package.json and package-lock.json files*

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Nidhi Manu <nmanu@yext.com>
#1169)

This PR removes styling that targets arbitrary `span`s in `Answers-resultsHeader`. This styling was being automatically applied to icons using the answers-search-ui partial (or other icons) when the `div`s were changed to `span`s for accessibility reasons, which caused visual regressions. This was only an issue on vertical full page map templates which include the search bar and nav tabs in `Answers-resultsHeader`, instead of just the results count and applied filters.

Based on the [PR](#900) that initially added this styling, this was needed to ensure results count elements had the correct ordering on both ltr and rtl experiences. I checked a vertical template and vertical full page map template for `en` and `ar` locales in the test site and the results count elements seem to still be flipped, as expected. The only other `span`s that I saw within `Answers-resultsHeader` seemed to be the nav More icon and applied filters, both of which seemed fine after removing this styling.

J=TECHOPS-11042
TEST=manual

Since we no longer have a paid Percy subscription, our snapshots are not being generated. So I've included some screenshots of pages after the changes in this PR, pointing to v1.16.6 of answers-search-ui which contains the icon `div` to `span` change:

**en:**
<img width="1008" alt="Screenshot 2024-02-20 at 9 08 26 AM" src="https://github.com/yext/answers-hitchhiker-theme/assets/88398086/a6165616-2316-43b0-9112-7bedf0912017">
<img width="1159" alt="Screenshot 2024-02-20 at 9 08 01 AM" src="https://github.com/yext/answers-hitchhiker-theme/assets/88398086/4338ec87-7c12-4588-842a-7d7836856f11">
<img width="1157" alt="Screenshot 2024-02-20 at 9 07 39 AM" src="https://github.com/yext/answers-hitchhiker-theme/assets/88398086/8296e98e-d853-48b6-ae41-4decdec084cb">

**ar:**
<img width="1007" alt="Screenshot 2024-02-20 at 9 09 00 AM" src="https://github.com/yext/answers-hitchhiker-theme/assets/88398086/159e1481-a389-4738-ae9e-ac9544202787">
<img width="1153" alt="Screenshot 2024-02-20 at 9 09 16 AM" src="https://github.com/yext/answers-hitchhiker-theme/assets/88398086/85d7d97b-a3b1-4b0d-9a2f-8752b2225d8e">
<img width="1157" alt="Screenshot 2024-02-20 at 9 09 37 AM" src="https://github.com/yext/answers-hitchhiker-theme/assets/88398086/b550063b-ff37-411b-91b2-840eeb8cc739">
Bump answers-search-ui version to 1.17 to get the change for switching icon `div`s to `span`s
@coveralls
Copy link

Coverage Status

coverage: 9.35% (+0.03%) from 9.317%
when pulling 8c7ce66 on hotfix/v1.33.5
into 15a7135 on master.

@nmanu1 nmanu1 merged commit b4bd5b5 into master Feb 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants