fix google streetview pegman on universal #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit fixed this on the vertical-map page template. We also need a fix for the map on universal, which also uses the SDK's map component. T=409037 TEST=manual, auto see mr.pegman on universal update the test-site's universal config to display a google maps component
cea2aj
reviewed
Jun 1, 2021
| "cardType": "multilang-financial-professional-location" | ||
| "cardType": "multilang-financial-professional-location", | ||
| "mapConfig": { | ||
| "mapProvider": "Google" |
There was a problem hiding this comment.
nit: Is switching this to google intentional or just for testing?
There was a problem hiding this comment.
just for testing, before this we didn't display a map on universal at all
cea2aj
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit fixed this on the vertical-map
page template. We also need a fix for the map
on universal, which also uses the SDK's map component.
T=409037
TEST=manual, auto
see mr.pegman on universal
update the test-site's universal config to display a google
maps component