Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DA cards feedback analytics #978

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Oct 13, 2021

Only show thumbs up/down feedback buttons on direct answer cards when user provides businessId and enables analytics.

J=SLAP-1175
TEST=manual

Smoke testing to check if feedback buttons only appear on DA cards when expected.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 8.988% when pulling 907fe03 on dev/fix-DA-analytics into de779cd on release/v1.25.

@nmanu1 nmanu1 merged commit dd89e78 into release/v1.25 Oct 13, 2021
@cea2aj cea2aj mentioned this pull request Oct 13, 2021
cea2aj added a commit that referenced this pull request Oct 13, 2021
## Version 1.25.0

### Features
- Facets can be sorted by optionsOrder (#968) (#972)

### Enhancements
- Improved performance on the locator map view on mobile (#954)
- Improved build validation (#962)
- Vertical icons are commented-out by default (#967)

### Bug Fixes
- Fixed a bug with Direct Answer analytics (#978)
- Improve locale support with the distance formatter (#795)
- The primary text color variable now applies to the body of all cards (#966)
cea2aj added a commit that referenced this pull request Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants