Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused mixins (#793) #795

Merged
merged 1 commit into from
May 26, 2021
Merged

Conversation

oshi97
Copy link
Contributor

@oshi97 oshi97 commented May 26, 2021

This commit removes css classes generated by UtilityLayouts.scss.
These classes (l-row-\*, l-col-\*, l-centeredColumn) are not used
anywhere in the theme or SDK. Removing these auto-generated
classes reduces the css bundle size from 267KB to 194KB.

J=SLAP-1298
TEST=manual

loaded up a page, ran a search, asked for a direct answer

This commit removes css classes generated by UtilityLayouts.scss.
These classes (`l-row-\*`, `l-col-\*`,  `l-centeredColumn`) are not used
anywhere in the theme or SDK. Removing these auto-generated
classes reduces the css bundle size from 267KB to 194KB.

J=SLAP-1298
TEST=manual

loaded up a page, ran a search, asked for a direct answer
@oshi97 oshi97 merged commit 25d08e9 into develop May 26, 2021
@oshi97 oshi97 deleted the feature/remove-utility-layout branch May 26, 2021 16:34
@coveralls
Copy link

Coverage Status

Coverage remained the same at 5.416% when pulling cbcd3e3 on feature/remove-utility-layout into 93b70ee on develop.

@cea2aj cea2aj mentioned this pull request Oct 13, 2021
cea2aj added a commit that referenced this pull request Oct 13, 2021
## Version 1.25.0

### Features
- Facets can be sorted by optionsOrder (#968) (#972)

### Enhancements
- Improved performance on the locator map view on mobile (#954)
- Improved build validation (#962)
- Vertical icons are commented-out by default (#967)

### Bug Fixes
- Fixed a bug with Direct Answer analytics (#978)
- Improve locale support with the distance formatter (#795)
- The primary text color variable now applies to the body of all cards (#966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants