Skip to content

Commit

Permalink
addComponent no longer throws error, prints to console instead
Browse files Browse the repository at this point in the history
If addComponent fails, we no longer throw an error, prints to console instead

TEST=manual
J=SLAP-1106

Threw an error in the component, and everything else loaded fine
  • Loading branch information
cjiang2000 committed Jun 4, 2021
1 parent 52bd12d commit ee7436a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/answers-umd.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import ErrorReporter from './core/errors/errorreporter';
import ConsoleErrorReporter from './core/errors/consoleerrorreporter';
import { AnalyticsReporter, NoopAnalyticsReporter } from './core';
import Storage from './core/storage/storage';
import { AnswersComponentError } from './core/errors/errors';
import AnalyticsEvent from './core/analytics/analyticsevent';
import StorageKeys from './core/storage/storagekeys';
import QueryTriggers from './core/models/querytriggers';
Expand Down Expand Up @@ -433,7 +432,7 @@ class Answers {
try {
this.components.create(type, opts).mount();
} catch (e) {
throw new AnswersComponentError('Failed to add component', type, e);
console.error('Failed to add component', type, e);
}
return this;
}
Expand Down

0 comments on commit ee7436a

Please sign in to comment.