Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summer language updates #1511

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Summer language updates #1511

merged 3 commits into from
Aug 17, 2021

Conversation

tmeyer2115
Copy link
Collaborator

@tmeyer2115 tmeyer2115 commented Aug 17, 2021

This PR adds translations for the following new languages: Arabic, Chinese (Traditional and Simplified), Polish, Portugese, Dutch, Swedish, Korea, Hindi, and Russian. Because new static text has been added for Speech Recognition, new translations were added to the existing language files as well.

A subsequent PR will update the constants.js file to include the new languages and their supported locales. Translations for the QA submission email errors will appear in a later PR, once Smartling is done with them.

TEST=none

@coveralls
Copy link

coveralls commented Aug 17, 2021

Coverage Status

Coverage remained the same at 60.499% when pulling ad70b5b on feature/summer-languages into f5edead on develop.

Copy link
Member

@cea2aj cea2aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Don't forget to update the description since the translation tests are now passing

@tmeyer2115 tmeyer2115 merged commit e7eb7a9 into develop Aug 17, 2021
@tmeyer2115 tmeyer2115 deleted the feature/summer-languages branch August 17, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants