Search bar v1.1.1 #1556
Merged
Search bar v1.1.1 #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the analytics for the search bar only assets When analyticsEventsEnabled was added to the SDK, the parameter order of the AnalyticsReporter constructor changed and it broke analytics for the search bar only assets. This caused analytics to only be sent if `analyticsOptions` was present in the config. The data sent was also messed up. Fix the parameter order so that it is the same as the regular SDK J=none TEST=manual Build the search bar only assets and test analytics with voice search and the clear button. See that analytics are properly sent even without analyticsOptions existing, and see that the data is now correct. Test `setAnalyticsOptIn` and confirm that it can disable analytics
yen-tt
approved these changes
Sep 24, 2021
tmeyer2115
pushed a commit
that referenced
this pull request
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes