Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar v1.1.1 #1556

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Search bar v1.1.1 #1556

merged 1 commit into from
Sep 24, 2021

Commits on Sep 24, 2021

  1. Search bar only analytics fix (#1555)

    Fix the analytics for the search bar only assets
    
    When analyticsEventsEnabled was added to the SDK, the parameter order of the AnalyticsReporter constructor changed and it broke analytics for the search bar only assets. This caused analytics to only be sent if `analyticsOptions` was present in the config. The data sent was also messed up.
    
    Fix the parameter order so that it is the same as the regular SDK
    
    J=none
    TEST=manual
    
    Build the search bar only assets and test analytics with voice search and the clear button. See that analytics are properly sent even without analyticsOptions existing, and see that the data is now correct. Test `setAnalyticsOptIn` and confirm that it can disable analytics
    cea2aj committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    702e751 View commit details
    Browse the repository at this point in the history