Add visitor support #1564
Merged
Add visitor support #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yen-tt
reviewed
Oct 7, 2021
yen-tt
reviewed
Oct 7, 2021
|
should update answers-search-bar as well to support visitor |
oshi97
reviewed
Oct 7, 2021
oshi97
reviewed
Oct 7, 2021
oshi97
reviewed
Oct 7, 2021
oshi97
reviewed
Oct 7, 2021
oshi97
approved these changes
Oct 8, 2021
cea2aj
reviewed
Oct 8, 2021
src/core/core.js
Outdated
| @@ -127,12 +127,13 @@ export default class Core { | |||
| /** | |||
| * Initializes the {@link Core} by providing it with an instance of the Core library. | |||
| */ | |||
| init () { | |||
| init (visitor) { | |||
There was a problem hiding this comment.
Can we have a config param instead that we spread into the params object? That way it's not specific to the visitor and the init could be written as oshi suggested: this.core.init({ visitor: parsedConfig.visitor });?
cea2aj
approved these changes
Oct 8, 2021
Merged
nmanu1
added a commit
that referenced
this pull request
Nov 16, 2021
## Version 1.12.0 ### Features - Allow search rate tracking (#1558) - Add support for setting and changing the visitor and passing it to answers-core (#1564) - Add support for the auth token that is passed in from the config (#1566) - Add an `environment` field to support consumer auth in Sandbox (#1597) - Allow components to override the beforeMount function (#1547) - Add distance to the card data and a function to format it (#1550) - WCAG updates (allow pagination with Enter (#1575), identify current page in navigation tab (#1576), update autocomplete screen reader support (#1578, #1579)) ### Changes - Update directAnswers component data to include the searcher (#1596) - Use custom alerts instead of window.alert (#1549) - Update Mapbox version to match the Theme (#1551) - Internal repo changes (#1562, #1577) ### Bugfixes - Fix console error which would appear on google maps (#1548) - Fix FAQ expansion when default is expanded (#1553) - Fix error for searches on page load with no businessId (#1561)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept visitor object in
initand allow visitor to be set or changed usingsetVisitor. If a visitor is set, it is passed to all analytics events and to a new Answers Core instance.J=SLAP-1620
TEST=auto, manual
Add jest tests for setting and changing the visitor. Check if visitor is sent during analytics events and searches in test-site.