Version 1.11 #1569
Merged
Version 1.11 #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR deprecates the serving of the latest assets off of the master branch Rather than pinning to latest, developers should pin to a version of Answers. This PR also makes the `subdirectory` param required for the `deploy-to-aws` command. In the `build_i18n` step of `build_and_deploy_hold`, now ignores all branches as only version tags should trigger it. Because we are ignoring all branches at the start of the workflow (in `build_i18n`), we no longer need to ignore all branches in the `deploy_version` step J=SLAP-1536 TEST=none I don't think we can fully test this until it gets merged into master. However we know the config is valid because otherwise Circle CI would throw an error Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Update caching strategy to include node version I looked into best practices and I wasn't able to find anyone that ran into problems with different node versions of the cache, however a similar problem frequently occurs when different architectures are used to build dependencies, and the solution is to include the architecture of the system in the cache key. So this approach is similar except we are adding the node version rather than the architecture to the cache key. We can include the node version dynamically, however we would need to migrate over to Circle CI dynamic configuration in order to supply the node version as a parameter to the circle CI config. J=SLAP-1547 TEST=manual Inspect the cache key in Circle CI and confirm that it is correct
Allow custom Handlebars partials to be registered, similar to templates and helpers. J=SLAP-1544 TEST=manual Local testing by adding and using a partial in theme
Add a getter for whether analytics is enabled or not. J=SLAP-1175 TEST=auto
Resolve merge conflicts for v1.11
yen-tt
previously approved these changes
Oct 13, 2021
oshi97
previously approved these changes
Oct 13, 2021
Bump core version to the latest version of 1.3.2 J=none TEST=manual Build the assets and smoke test with a sample site
yen-tt
approved these changes
Oct 13, 2021
oshi97
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.11
Features