Support/test gh actions #1657
Closed
Support/test gh actions #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ANSWERS.setGeolocation to all acceptance testing fixtures. Without these, a number of acceptance tests would pretty consistently fail. This seems to have been due to GH runners having a different location than CircleCI runners, resulting in different API responses. J=SLAP-1815 TEST=auto
oshi97
added a commit
that referenced
this pull request
Jan 28, 2022
Added ANSWERS.setGeolocation to all acceptance testing fixtures. Without these, a number of acceptance tests would pretty consistently fail. This seems to have been due to GH runners having a different location than CircleCI runners, resulting in different API responses. We already set the geolocation in the theme's acceptance tests. I included the useragent tests in the acceptance test workflow, despite them also being considered part of "miscellaneous tests". I felt like it's nice to have all the browserstack tests in one place. J=SLAP-1815 TEST=manual,auto see the acceptance tests run in parallel saw that the `if` statement in the acceptance script works #1657
cea2aj
added a commit
that referenced
this pull request
Apr 4, 2022
Added ANSWERS.setGeolocation to all acceptance testing fixtures. Without these, a number of acceptance tests would pretty consistently fail. This seems to have been due to GH runners having a different location than CircleCI runners, resulting in different API responses. We already set the geolocation in the theme's acceptance tests. I included the useragent tests in the acceptance test workflow, despite them also being considered part of "miscellaneous tests". I felt like it's nice to have all the browserstack tests in one place. J=SLAP-1815 TEST=manual,auto see the acceptance tests run in parallel saw that the `if` statement in the acceptance script works #1657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.