Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support/test gh actions #1657

Closed
wants to merge 5 commits into from
Closed

Support/test gh actions #1657

wants to merge 5 commits into from

Commits on Jan 27, 2022

  1. use GH actions for acceptance tests 

    Added ANSWERS.setGeolocation to all acceptance testing fixtures.

Without these, a number of acceptance tests would pretty consistently fail.
This seems to have been due to GH runners having a different location than
CircleCI runners, resulting in different API responses.

J=SLAP-1815
TEST=auto
    @oshi97
    oshi97 committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    fdfca43 View commit details
    Browse the repository at this point in the history

  2. forgot to save changes

    @oshi97
    oshi97 committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    3e3d200 View commit details
    Browse the repository at this point in the history

  3. add back skipJsErrors

    @oshi97
    oshi97 committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    dfcfdb7 View commit details
    Browse the repository at this point in the history

  4. logging

    @oshi97
    oshi97 committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    ca5f9b2 View commit details
    Browse the repository at this point in the history

  5. dont ignore me

    @oshi97
    oshi97 committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    a493cb0 View commit details
    Browse the repository at this point in the history