test #1745
Closed
test #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master (v1.14.0) into develop
This PR updates the `build_and_deploy_i18n` workflow to run a simplified build before the acceptance tests instead of the full i18n build. This shortens the amount of time it takes before we see the results of the acceptance tests. The simplified build is the same as the `dev` build, but without the watch task. The i18n build runs in parallel and still must complete successfully before the deploy jobs are run. The `build_and_deploy_hold` workflow also runs the i18n build, but another item (SLAP-2103) plans to remove the acceptance tests from this workflow, so it doesn't seem necessary to update it to run a simplified build. J=SLAP-2099 TEST=auto Tested on another branch (`test-basic-build`) and saw that the acceptance and unit tests run once the basic build is complete, the i18n build runs in parallel, and the deploy waits until both the tests and the i18n build finish.
yen-tt
added a commit
that referenced
this pull request
May 17, 2022
Rendering failures leading to the catch statements in Universal and Vertical search would clear all results. User would still expects other results from the response to render on page. This pr updates the `storage.set` calls to only update the searchState, instead of storing a new empty results, so the non-problematic result sets can still be render. The catch statements in core.js will terminate any further rendering of sub components once it encounter a problematic sub component. User expects sdk to render as much as it can. To ensure non-problematic sub-components can still render, this pr added more catch statements in component.js to gracefully handle errors coming from individual child component's data transformation, initialization and mount stage. J=none TEST=manual use `dev-keep-data-on-search-failure` for SDK version ([from this test branch](#1745)) in the config file of the site with the issue. Searched 'Listings', and see that the same error appeared in console but the other cards still render as normal. use `dev-dont-clear-data-on-failure` to test changes in this pr through local html pages that use SDK directly. See that errors are logged but the loading icon is reset to complete during error handling process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering failures leading to the catch statements in Universal and Vertical search would clear all results. User would still expects other results from the response to render on page. This pr removes the
storage.setcalls so the non-problematic result sets can still be render.J=none
TEST=manual
use
dev-keep-data-on-search-failurefor SDK version in the config file of the site with the issue. Searched 'Listings', and see that the same error appeared in console but the other cards still render as normal.