Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.16.4 #1848

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Version 1.16.4 #1848

merged 1 commit into from
Dec 1, 2023

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Dec 1, 2023

Fixes

  • Updated @yext/search-core to v2.4.0 to properly support new Rich Text & Markdown field types returned as raw html in direct answers (Bump Core to v2.4.0 #1847)

This PR bumps the `search-core` version to v2.4.0 to get support for new Rich Text & Markdown field types returned as
raw html in direct answers (see [release notes](https://github.com/yext/search-core/releases/tag/v2.4.0)). We had already added [support](yext/answers-hitchhiker-theme#1138) to render these fields in the Theme, but without the Core update, a search that returns an `html` field type gives an error and doesn't actually get rendered.

J=TECHOPS-10638
TEST=manual

Point the site from the techops to a locally served version of the SDK with this version bump and see that an HTML field type for a featured snippet direct answer is properly rendered instead of throwing an error.

<img width="1728" alt="Screenshot 2023-11-30 at 4 55 46 PM" src="https://github.com/yext/answers-search-ui/assets/88398086/82233e9d-9d1e-4e26-960a-8b579a0eac4c">

Note: this PR is the same as #1843, but with a corrected version bump (v1.16.4 instead of v1.16.3)
Copy link
Contributor Author

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is the same as the one approved in #1844, except with the correct version (v1.16.4 instead of v1.16.3)

@coveralls
Copy link

Coverage Status

coverage: 61.411%. remained the same
when pulling e24293e on hotfix/v1.16.4
into cc55531 on master.

@nmanu1 nmanu1 merged commit 0f8a1a6 into master Dec 1, 2023
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants