-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Workflow Versions to Remove node16 Deprecation Warnings #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanu1
reviewed
May 8, 2024
nmanu1
reviewed
May 10, 2024
nmanu1
reviewed
May 10, 2024
nmanu1
reviewed
May 11, 2024
nmanu1
approved these changes
May 11, 2024
jesuyedavid
added a commit
that referenced
this pull request
May 13, 2024
**Changes** - Update Workflow Versions to Remove node16 Deprecation Warnings (#1877)
Fondryext
pushed a commit
that referenced
this pull request
Jun 28, 2024
**Changes** - Update Workflow Versions to Remove node16 Deprecation Warnings (#1877)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable Changes:
We added two new jobs:
merge_multiple_artifacts
andoverwrite_artifact
in.github/workflows/build_i18n.yml
to handle merging multiple locale files into thebuild-output-US
andbuild-output-EU
artifacts. This was necessary since we have to handle no longer being able to have multiple jobs in the same workflow write to one artifact name and mutate it, a breaking change inaction/upload-artifact@v4
. Sincebuild_and_deploy_i18n.yml
calls bothbuild.yml
andbuild_i18n.yml
, we can't have both write an artifact calledbuild-output-US
unless we pass theoverwrite: true
input in the latter. Theaction/upload-artifact/merge@v4
doesn't allow overwriting, so we need an additional step of merging and uploading with a temporary name and then downloading the merged artifact and re-uploading to overwrite the correct name.We bumped
google-github-actions/auth
andgoogle-github-actions/upload-cloud-storage
from v0 to v2Updated
actions/checkout
,actions/setup-node
,actions/upload-artifact
,actions/download-artifact
, andaws-actions/configure-aws-credentials
actions to v4J=WAT-4020
TEST=manual
Testing was done in a forked repo. View actions to see testing details and test commits. We also checked the US/EU build artifact unzipped files to ensure they are uploaded to AWS/GCP properly and that they look similar to build files prior to this update. Finally, we did local testing from the Answers-Hitchhiker-Theme repo's test site that pointed to our dev assets in AWS. The
dev
bucket in GCP did not have the correct permissions to allow local testing, so this local testing will be done after merging this PR and the changes from develop are pushed tocanary
in GCP.