Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Workflow Versions to Remove node16 Deprecation Warnings #1877

Merged
merged 22 commits into from
May 11, 2024

Conversation

jesuyedavid
Copy link
Contributor

@jesuyedavid jesuyedavid commented May 1, 2024

Notable Changes:

  1. We added two new jobs: merge_multiple_artifacts and overwrite_artifact in .github/workflows/build_i18n.yml to handle merging multiple locale files into the build-output-US and build-output-EU artifacts. This was necessary since we have to handle no longer being able to have multiple jobs in the same workflow write to one artifact name and mutate it, a breaking change in action/upload-artifact@v4. Since build_and_deploy_i18n.yml calls both build.yml and build_i18n.yml, we can't have both write an artifact called build-output-US unless we pass the overwrite: true input in the latter. The action/upload-artifact/merge@v4 doesn't allow overwriting, so we need an additional step of merging and uploading with a temporary name and then downloading the merged artifact and re-uploading to overwrite the correct name.

  2. We bumped google-github-actions/auth and google-github-actions/upload-cloud-storage from v0 to v2

  3. Updated actions/checkout, actions/setup-node, actions/upload-artifact, actions/download-artifact, and aws-actions/configure-aws-credentials actions to v4

J=WAT-4020
TEST=manual

Testing was done in a forked repo. View actions to see testing details and test commits. We also checked the US/EU build artifact unzipped files to ensure they are uploaded to AWS/GCP properly and that they look similar to build files prior to this update. Finally, we did local testing from the Answers-Hitchhiker-Theme repo's test site that pointed to our dev assets in AWS. The dev bucket in GCP did not have the correct permissions to allow local testing, so this local testing will be done after merging this PR and the changes from develop are pushed to canary in GCP.

@jesuyedavid jesuyedavid requested a review from a team as a code owner May 1, 2024 19:52
@jesuyedavid jesuyedavid assigned jesuyedavid and nmanu1 and unassigned jesuyedavid May 1, 2024
@coveralls
Copy link

coveralls commented May 1, 2024

Coverage Status

coverage: 62.092%. remained the same
when pulling 856f988 on dev/update-workflow
into ee4333d on develop.

@jesuyedavid jesuyedavid marked this pull request as draft May 1, 2024 20:05
@jesuyedavid jesuyedavid marked this pull request as ready for review May 8, 2024 01:49
.github/workflows/deploy_hold.yml Show resolved Hide resolved
.github/workflows/build_and_deploy_hold.yml Outdated Show resolved Hide resolved
.github/workflows/deploy_hold.yml Show resolved Hide resolved
.github/workflows/build_and_deploy_hold.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_deploy.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_deploy_i18n.yml Outdated Show resolved Hide resolved
.github/workflows/build_i18n.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_deploy.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_deploy_i18n.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
@jesuyedavid jesuyedavid merged commit 7ab71e9 into develop May 11, 2024
13 of 14 checks passed
@jesuyedavid jesuyedavid deleted the dev/update-workflow branch May 11, 2024 00:24
jesuyedavid added a commit that referenced this pull request May 13, 2024
**Changes**

- Update Workflow Versions to Remove node16 Deprecation Warnings (#1877)
Fondryext pushed a commit that referenced this pull request Jun 28, 2024
**Changes**

- Update Workflow Versions to Remove node16 Deprecation Warnings (#1877)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants