Fix generate notices script #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbramblett
approved these changes
Jul 12, 2024
anguyen-yext2
pushed a commit
that referenced
this pull request
Jul 15, 2024
Github actions were failing ([PR](#40)) at the generate notices step because both `chat-core` and `chat-core-aws-connect` attempt to run the script in the same `temp/` folder, and deleting/overriding over each other. This PR updates the generate-notices.sh script to use specific temp folder (`temp-{packageName}`) when generating build and notices. Also removed top level LICENSE file. Each packages should provide their own in their respective folder already. TEST=manual&auto successfully ran `npm run build` in root directory see [commit](785a297) below where all GH actions passed with a version bump for chat-core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github actions were failing (PR) at the generate notices step because both
chat-coreandchat-core-aws-connectattempt to run the script in the sametemp/folder, and deleting/overriding over each other.This PR updates the generate-notices.sh script to use specific temp folder (
temp-{packageName}) when generating build and notices.Also removed top level LICENSE file. Each packages should provide their own in their respective folder already.
TEST=manual&auto
successfully ran
npm run buildin root directorysee commit below where all GH actions passed with a version bump for chat-core.