Answers to Search (3): Rename request, error, and core #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2624289900
💛 - Coveralls |
oshi97
reviewed
Jul 5, 2022
nmanu1
reviewed
Jul 6, 2022
alextaing
force-pushed
the
dev/request-error-core
branch
from
45f994a
to
0bbca61
Compare
|
Could we update the Full Documentation link here to point to the new docs page? The current URL is no longer valid, can just change answers to search in the url. Also the "our documentation" link at the bottom (I think that's it but also any others you find in the readme) |
oshi97
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the following interfaces:
AnswersRequest -> SearchRequest
AnswersError -> SearchError
AnswersCore -> SearchCore
Updated README