Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextValueDirectAnswer interface. #206

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Commits on Aug 15, 2022

  1. Add StringValueDirectAnswer interface.

    This PR creates the `StringValueDirectAnswer` interface, which
    describes a direct answer sourced from a string (or string list) field
    in the Knowledge Graph.
    
    J=SLAP-2315
    TEST=manual
    
    I made a few code changes locally which are not included in this PR. These
    changes allowed me to generate a switch statement on `fieldType`. I added
    cases for `single_line_text` and `multi_line_text`. These cases were hit as
    expected when getting direct answers for string and string list fields. In
    these switch statements, I saw the IDE correctly inferring that the DA was a
    `StringValueDirectAnswer`.
    tmeyer2115 committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    5a84aba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a4435b3 View commit details
    Browse the repository at this point in the history
  3. Add EnumOrLiteral.

    tmeyer2115 committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    0a27898 View commit details
    Browse the repository at this point in the history
  4. Rename model.

    tmeyer2115 committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    b0fe8e1 View commit details
    Browse the repository at this point in the history