Add inputIntents to AutocompleteResult #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4512590451
💛 - Coveralls |
nmanu1
reviewed
Mar 23, 2023
| /** | ||
| * {@link SearchIntent}s corresponding to the autocomplete result. | ||
| */ | ||
| queryIntents: SearchIntent[] |
There was a problem hiding this comment.
What's the reason for naming this field queryIntents, when the similar field in AutocompleteResponse is called inputIntents?
tmeyer2115
approved these changes
Mar 24, 2023
oshi97
changed the title
Merged
oshi97
added a commit
that referenced
this pull request
Mar 24, 2023
### Changes * Adds inputIntents to AutocompleteResult (#230)
oshi97
added a commit
that referenced
this pull request
Mar 24, 2023
* Adds inputIntents to AutocompleteResult (#230)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds AutocompleteResult.inputIntents.
T=TECHOPS-8462
TEST=auto,manual
saw that this would fix the related techops for missing query intents