Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSR Support #115

Merged
merged 6 commits into from
Apr 22, 2022
Merged

SSR Support #115

merged 6 commits into from
Apr 22, 2022

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented Apr 22, 2022 •
edited
Loading

Add SSR support by adding "type": "module" and useIsomorphicLayoutEffect

By setting "type": "module", node treats the javascript files within the package as ES modules. Since some of the config files are CJS, we need to indicate that by updating the file extension from '.js' to '.cjs' or else node 16+ will throw an error

J=none
TEST=manual

Connect this to the SSR Support branch in the component library and smoke test with the Yext Sites starter

@cea2aj cea2aj changed the base branch from main to develop April 22, 2022 15:51
@cea2aj cea2aj requested a review from a team as a code owner April 22, 2022 15:51
@cea2aj cea2aj added the wip Work in progress label Apr 22, 2022
@tmeyer2115 tmeyer2115 self-requested a review April 22, 2022 16:44
@coveralls
Copy link

coveralls commented Apr 22, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 69.725% when pulling 5773b4a on dev/ssr-support into c51aea7 on develop.

@cea2aj cea2aj removed the wip Work in progress label Apr 22, 2022
@cea2aj cea2aj requested a review from nmanu1 April 22, 2022 17:41
@cea2aj cea2aj merged commit 25d21c2 into develop Apr 22, 2022
@cea2aj cea2aj deleted the dev/ssr-support branch April 22, 2022 18:42
@tmeyer2115 tmeyer2115 mentioned this pull request May 11, 2022
Merged
tmeyer2115 added a commit that referenced this pull request May 11, 2022
@tmeyer2115
v1.1.0
7477da0 
## Version 1.1.0
### Features
- Support was added for Server-Side Rendering of our React Components. (#115)
- A CommonJS distribution of the library was added. (#118)
- Answers Agent information can be passed through to Headless. (#110)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmanu1 nmanu1 nmanu1 approved these changes

@tmeyer2115 tmeyer2115 Awaiting requested review from tmeyer2115

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cea2aj @coveralls @tmeyer2115 @nmanu1