Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass Client-SDK agent to Headless #110

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Pass Client-SDK agent to Headless #110

merged 2 commits into from
Mar 18, 2022

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Mar 18, 2022 •
edited
Loading

Passes the ANSWERS_HEADLESS_REACT agent as part of the Client-SDK header to Headless through provideAnswersHeadless.

J=SLAP-1951
TEST=manual

Hook up locally to the starter app and see that requests send the Headless React, Headless, and Core agents as part of the Client-SDK header. Requests to the universal search endpoint made for entity previews only send the Headless and Core agents because the hook uses provideAnswersHeadless directly to get an instance of Headless instead of going through the AnswersHeadlessProvider component from Headless React.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 69.444% when pulling 3784a14 on dev/client-sdk into ce09711 on develop.

cea2aj
cea2aj approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@cea2aj cea2aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oshi97
oshi97 approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@oshi97 oshi97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PogChamp !!

@nmanu1 nmanu1 merged commit 75b1f03 into develop Mar 18, 2022
@nmanu1 nmanu1 deleted the dev/client-sdk branch March 18, 2022 20:20
@tmeyer2115 tmeyer2115 mentioned this pull request May 11, 2022
Merged
tmeyer2115 added a commit that referenced this pull request May 11, 2022
@tmeyer2115
v1.1.0
7477da0 
## Version 1.1.0
### Features
- Support was added for Server-Side Rendering of our React Components. (#115)
- A CommonJS distribution of the library was added. (#118)
- Answers Agent information can be passed through to Headless. (#110)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cea2aj cea2aj cea2aj approved these changes

@oshi97 oshi97 oshi97 approved these changes

@yen-tt yen-tt Awaiting requested review from yen-tt

@tmeyer2115 tmeyer2115 Awaiting requested review from tmeyer2115

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nmanu1 @coveralls @oshi97 @cea2aj