Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.3.0 #119

Merged
merged 12 commits into from
Jul 14, 2022
Merged

v1.3.0 #119

merged 12 commits into from
Jul 14, 2022

Conversation

ElemelonWind
Copy link
Contributor

@ElemelonWind ElemelonWind commented Jul 13, 2022 •
edited
Loading

Version 1.3.0

@yext/answers-headless is now @yext/search-headless! This means that much of the answers terminology is now deprecated and have been replaced by new search terms.

Changes

  • The following identifiers were renamed in (Answers -> Search renaming #116):
    • answersUtilities → searchUtilities
    • provideAnswersHeadless → provideHeadless
    • AnswersHeadless → SearchHeadless
  • Additionally, direct exports from what was previously @yext/answers-core have been replaced by their @yext/search-core counterparts:
    • AnswersConfig → SearchConfig
    • AnswersConfigWithToken → SearchConfigWithToken
    • AnswersConfigWithApiKey → SearchConfigWithApiKey
    • AnswersCore → SearchCore
    • AnswersError → SearchError
    • AnswersRequest → SearchRequest
    • BaseAnswersConfig → BaseSearchConfig

nmanu1 and others added 11 commits June 16, 2022 14:32
@nmanu1
Merge main into develop (#102)
247c704 
Merge main into develop
@alextaing
edited license to package.json and updated year in LICENSE (#104)
dcc068e 
Edited license to BSD-3-Clause in package.json and package-lock.json, and updated year to 2022 in LICENSE.

J=SLAP-2161
TEST=none
@oshi97
update eslint-config-slapshot to 0.4.0 (#105)
27e4fcb 
Addresses some style nits.

J=SLAP-2135
TEST=none
@alextaing
Add official release workflows (#107)
397440f 
`version_update` and `sync_develop_and_main` workflows were added.

J=SLAP-2159
TEST=manual

Forked this repo, made a release branch and merged into main.  2 PRs were made: one updating for package version and one for merging main into develop.
@juliannzhou
add reusable workflow for ESlint to answers-headless (#106)
bb1642b 
This PR adds reusable workflow for ESlint to answers-headless.

J=SLAP-2199
TEST=auto
@juliannzhou
add description and keywords to package.json (#114)
d7f2df4 
This PR adds description and keywords to package.json. The description is copied from README and keywords approved by product.

J=SLAP-2190
TEST=manual
@ElemelonWind
package.json edits (#115)
8901628
@ElemelonWind @github-actions
Answers -> Search 2: headless unique customer components (#113)
da871b1 
* Customer facing renaming

* API extracted

* update test site

* Update index.ts

* Addressed comments

* fix provideHeadless

* API update for SearchHeadless

* Automated update to repo's documentation from github action

* update exports

* export from deprecated

* renamed files

* file edits

* rm ds store

* gitignore fix

* minor fixes

* Automated update to repo's documentation from github action

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@ElemelonWind @github-actions
Answers -> Search 3: Replacing search-core imports (#117)
a70ab0d 
* Customer facing renaming

* API extracted

* update test site

* Update index.ts

* Addressed comments

* fix provideHeadless

* API update for SearchHeadless

* Automated update to repo's documentation from github action

* answers-core -> search-core

* update exports

* export from deprecated

* renamed files

* file edits

* rm ds store

* gitignore fix

* minor fixes

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

* Automated update to repo's documentation from github action

* export deprecated answers-core things

* fix link

* Automated update to repo's documentation from github action

* replaced some imports from search-core in index

* rename answers-core.ts

* update lib and meta.ts

* Automated update to repo's documentation from github action

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@ElemelonWind
Merge branch 'develop' into feature/answers-to-search
0f5bcc9 
merge with develop
.
@ElemelonWind
Merge pull request #116 from yext/feature/answers-to-search
a087fa6 
Answers -> Search renaming
@ElemelonWind ElemelonWind marked this pull request as ready for review July 13, 2022 18:32
@ElemelonWind ElemelonWind requested a review from a team as a code owner July 13, 2022 18:32
@oshi97
Copy link
Contributor

oshi97 commented Jul 13, 2022

Could you type up some release notes? Can look at alex's for search-core or other past ones for reference but also feel free to write them your own way! Then the release notes will be the PR description here

@oshi97
Copy link
Contributor

oshi97 commented Jul 13, 2022

in terms of changes you only need to talk about the renaming and maybe adding keywords to the package.json

@github-actions
Update Package Version to v1.3.0 (#118)
e67be9d 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ElemelonWind
Copy link
Contributor Author

Could you type up some release notes? Can look at alex's for search-core or other past ones for reference but also feel free to write them your own way! Then the release notes will be the PR description here

done :) can you look over it?

nmanu1
nmanu1 reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@nmanu1 nmanu1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also update the PR name and the name of the commit when you merge it in (e.g. something like Version 1.3.0 or v1.3.0 )?

@ElemelonWind ElemelonWind changed the title Release/v1.3.0 v1.3.0 Jul 13, 2022
@ElemelonWind
Copy link
Contributor Author

can you also update the PR name and the name of the commit when you merge it in (e.g. something like Version 1.3.0 or v1.3.0 )?

How do you change the name of the commit lol

@nmanu1
Copy link
Contributor

nmanu1 commented Jul 13, 2022 •
edited
Loading

How do you change the name of the commit lol

I meant when you're going to merge it into main (i.e. when you click "Merge pull request" at the bottom), you should set the name of the commit and the commit message to match the PR title and description, respectively

@oshi97
Copy link
Contributor

oshi97 commented Jul 13, 2022

Also make sure to merge commit this one! We wanna keep all the separate commits

@ElemelonWind ElemelonWind merged commit 0e9082f into main Jul 14, 2022
@ElemelonWind ElemelonWind deleted the release/v1.3.0 branch July 14, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmanu1 nmanu1 nmanu1 left review comments

@oshi97 oshi97 oshi97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ElemelonWind @oshi97 @nmanu1 @alextaing @juliannzhou