Answers -> Search renaming #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds description and keywords to package.json. The description is copied from README and keywords provided by product. J=SLAP-2190 TEST=manual
* Customer facing renaming * API extracted * update test site * Update index.ts * Addressed comments * fix provideHeadless * API update for SearchHeadless * Automated update to repo's documentation from github action * update exports * export from deprecated * renamed files * file edits * rm ds store * gitignore fix * minor fixes * Automated update to repo's documentation from github action Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Customer facing renaming * API extracted * update test site * Update index.ts * Addressed comments * fix provideHeadless * API update for SearchHeadless * Automated update to repo's documentation from github action * answers-core -> search-core * update exports * export from deprecated * renamed files * file edits * rm ds store * gitignore fix * minor fixes * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Automated update to repo's documentation from github action * export deprecated answers-core things * fix link * Automated update to repo's documentation from github action * replaced some imports from search-core in index * rename answers-core.ts * update lib and meta.ts * Automated update to repo's documentation from github action Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
|
Could we have a PR to update variable names and test fixture names? If that's going to be a separate thing lgtm! |
Yeah I just confirmed with Tom yesterday, internal stuff is going to be another phase of the renaming :) |
nmanu1
reviewed
Jul 13, 2022
Is the npm package going to be from |
we would merge into |
merge with develop .
oshi97
approved these changes
Jul 13, 2022
aah got it ty! |
Pull Request Test Coverage Report for Build 2665475341
💛 - Coveralls |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J=SLAP-2204
TEST=auto