Address trim and terser vulnerabilities. #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snyk highlighted issues with the trim and terser transitive dependencies. I manually edited the package-lock.json to update the versions of these two dependencies. The new versions have fixes for the various security vulnerabilities. TEST=manual Made sure I could build the Storybook site and all looked as expected. The transitive dependencies were ultimately dependencies of Storybook.
oshi97
reviewed
Jul 19, 2022
oshi97
previously approved these changes
Jul 19, 2022
oshi97
approved these changes
Jul 19, 2022
yen-tt
pushed a commit
that referenced
this pull request
Sep 28, 2022
Snyk highlighted issues with the trim and terser transitive dependencies. I manually edited the package-lock.json to update the versions of these two dependencies. The new versions have fixes for the various security vulnerabilities. TEST=manual Made sure I could build the Storybook site and all looked as expected. The transitive dependencies were ultimately dependencies of Storybook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk highlighted issues with the trim and terser transitive dependencies.
I manually edited the package-lock.json to update the versions of these
two dependencies. The new versions have fixes for the various security
vulnerabilities.
TEST=manual
Made sure I could build the Storybook site and all looked as expected.
The transitive dependencies were ultimately dependencies of Storybook.