Update Workflow Versions to Remove node16 Deprecation Warnings #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-react into dev/update-workflows
jesuyedavid
force-pushed
the
dev/update-workflows
branch
from
81edfa9
to
05af371
Compare
nmanu1
reviewed
May 3, 2024
nmanu1
reviewed
May 14, 2024
nmanu1
reviewed
May 14, 2024
|
Current unit coverage is 92.20456802383316% |
nmanu1
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In accordance with [3] of this PR, we updated
coverage.ymlto useactions/download-artifact@v4.main.yml, andupdate-snapshots.ymlactions of this repo were also updated to stop the node 16 deprecation warningsBumped versions for peter-evans/create-or-update-comment to v4, peter-evans/find-comment to v3, and actions/github-script to v7.
J=WAT-3818
TEST=manual
Testing
Set
slapshot-reusable-workflowsin this repo to its main branch in the first commit of this PR and making sure that no build warnings show up.In
coverage.yml, all jobs run with no warnings upon v4 updatesIn
main.yml, semgrep runs successfully with checkout actions upgradeIn
update_snapshots.yml,Fail job if push changesstep fails without warning after settingactions/github-scriptto v7Deleted some tests to reduce code coverage percentage and then checked that we're still able to find a previous comment and update it successfully. Deleted previous comment and reran workflow to test that new coverage comment can be created.