Updated coverage workflow to satisfy node20 requirements #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijay267
reviewed
Apr 16, 2024
sorry, this is not ready for actual review. we are testing things out and debugging code coverage percentage reduction. sorry, is should i have written it in the description somewhere. |
fyi, you can add a wip label to the PR or change it to a draft if you want to indicate that it's not ready for review |
jesuyedavid
changed the title
nmanu1
reviewed
Apr 17, 2024
nmanu1
reviewed
Apr 17, 2024
nmanu1
approved these changes
Apr 17, 2024
Merged
This was referenced May 1, 2024
jesuyedavid
added a commit
to yext/search-ui-react
that referenced
this pull request
May 14, 2024
### Changes 1. In accordance with [3] of [this PR](yext/slapshot-reusable-workflows#37), we updated `coverage.yml` to use `actions/download-artifact@v4`. 2. `main.yml`, and `update-snapshots.yml` actions of this repo were also updated to stop the node 16 deprecation warnings 3. Bumped versions for [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment/releases) to v4, [peter-evans/find-comment](https://github.com/peter-evans/find-comment/releases) to v3, and [actions/github-script](https://github.com/actions/github-script/releases?page=3) to v7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated .github/workflows/coverage.yml to use new workflow action versions so as to get rid of previous node16 deprecation warnings after workflow builds.
Some things to note:
We bumped
actions/checkout,actions/setup-node,actions/upload-artifact,actions/download-artifactto their respective versions 4.Updated
coverallsapp/github-actionto use version 2, which now requires us to specify acoverage/lcov.infoin the build action because according to Coveralls' release notes here, v2 automatically tries to find all supported coverage files and then combine their data.coverage/lcov.infowas the previous default file path for the coverage file used by node-coveralls and we're now manually specifying the path so there's no behavior change from from the above update.Because we're updating the upload action to v4, any repo that downloads the coverage (which seems to just be
search-ui-react) will need to upgrade their download action to v4J=WAT-3813
Tested by pointing some libraries that depend on this workflow to this workflow branch and seeing that deprecation warnings have disappeared.