Add analytics clicks event and update page views event #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephh2
force-pushed
the
analytics
branch
2 times, most recently
from
4e800ab
to
1d385ce
Compare
bhainesva
reviewed
Nov 3, 2021
| @@ -27,7 +27,7 @@ type AnalyticsData struct { | |||
| AverageRating *float64 `json:"Average Rating"` | |||
| NewReviews *int `json:"Reviews"` | |||
| StorepagesSessions *int `json:"Storepages Sessions"` | |||
| StorepagesPageviews *int `json:"Page Views"` | |||
| StorepagesPageviews *int `json:"Pages Views"` | |||
There was a problem hiding this comment.
sorry I don't have much context, did this change or was the old value just wrong?
if they changed the name behind a v param or something we would need to handle being able to unmarshal either version right?
There was a problem hiding this comment.
It didn't change This was just wrong from get go I believe
bhainesva
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.