Fix build entry and module path for browser #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many bundlers for browser (Browserify, webpack etc) would respect the browser field in package.json. But these bundler should use ES5 module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have made 2 sad mistakes. 馃槆
First: This plugin could never used with any bundler for browser (Browserify, webpack etc).
require('markdown-it-incremental-dom')would returnundefined. Who did disable eslint rule ofprefer-default-export? It's me 馃檭Second: Removed
browserfield in package.json. The bundler for browser respects this field but JS is already bundled. We should provide ES5 module bymainfield.Of course we would be continue providing build for browser. (
dist/markdown-it-incremental-dom[.min].js)