Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build entry and module path for browser #27

Merged
merged 4 commits into from
Feb 14, 2018
Merged

Fix build entry and module path for browser #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0ca243
Provide default export for browser build
yhatt Feb 14, 2018
90fefe3
Remove browser field from package.json
yhatt Feb 14, 2018
c8bcc9f
Correct misspell in README.md
yhatt Feb 14, 2018
c8d7ff2
Update CHANGELOG.md
yhatt Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixed

* Fix format script to work globstar correctly ([#26](https://github.com/yhatt/markdown-it-incremental-dom/pull/26))
* Fix build entry and module path for browser ([#27](https://github.com/yhatt/markdown-it-incremental-dom/pull/27))

## v1.2.0 - 2018-01-15

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ require('markdown-it')().use(
)
```

* **`incrementalizeDefaultRules`**: For better performance, this plugin would override a few default renderer rules only when you calls injected methods. If the other plugins that override default rules have occured any problem, You can disable overriding by setting `false`. _(`true` by default)_
* **`incrementalizeDefaultRules`**: For better performance, this plugin would override a few default renderer rules only when you calls injected methods. If the other plugins that override default rules have occurred any problem, You can disable overriding by setting `false`. _(`true` by default)_

### Rendering methods

Expand Down
2 changes: 1 addition & 1 deletion entry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable import/prefer-default-export */
import markdownitIncrementalDOM from './src/markdown-it-incremental-dom'

export { markdownitIncrementalDOM }
export default markdownitIncrementalDOM
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"version": "1.2.0",
"description": "markdown-it renderer plugin by using Incremental DOM.",
"main": "lib/markdown-it-incremental-dom.js",
"browser": "dist/markdown-it-incremental-dom.js",
"engines": {
"node": ">=4.2.0"
},
Expand Down
4 changes: 2 additions & 2 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ https://github.com/fb55/htmlparser2/raw/master/LICENSE
@license ${packageConfig.license}
${packageConfig.repository.url}/raw/master/LICENSE`

const basename = path.basename(packageConfig.browser, '.js')
const basename = path.basename(packageConfig.main, '.js')
const browsers = ['> 1%', 'last 2 versions', 'Firefox ESR', 'IE >= 9']

exports.default = {
Expand All @@ -22,7 +22,7 @@ exports.default = {
[`${basename}.min`]: './entry.js',
},
output: {
path: path.resolve(__dirname, path.dirname(packageConfig.browser)),
path: path.resolve(__dirname, 'dist'),
filename: '[name].js',
libraryTarget: 'umd',
umdNamedDefine: true,
Expand Down