Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for opening files that don't exist #1

Closed
wants to merge 6 commits into from

Conversation

vasil-nesterov
Copy link
Contributor

@vasil-nesterov
Copy link
Contributor Author

Cautious-file uses canonicalizePath itself. If you try to save file that doesn't exist, you'll get the same error (on GHC >= 7.0.1).

@jeffwheeler
Copy link
Member

Hmm, alright. I think I'll pull this, but file a bug with cautious-file. If/when it's fixed, we can uncomment it.

@jeffwheeler
Copy link
Member

(I think the package could also support Windows out-of-the-box now with some *.cabal work, which would mean we could get rid of the preprocessor flags altogether.)

If you want to jump on this, Hackage lists Robin Green as the maintainer of that package; it'll be a few days before I can email about this bug, but go ahead if you want.

@vasil-nesterov
Copy link
Contributor Author

Ok, I've informed Robin Green about problems with cautious-file.

@jeffwheeler
Copy link
Member

Looks great now! Thanks for pinging Robin, also.

I'm ready to pull the commits, but why did you delete .gitignore?

@vasil-nesterov
Copy link
Contributor Author

Hm, I haven't thought about problems it might cause. If it makes merging troublesome, I'll put it back.

@jeffwheeler
Copy link
Member

Applied; thanks!

(Although I kinda made a mess of applying it . . . pushed it to my own github copy first, then pulled the commits to the main repo from there rather than doing a proper merge. Oh well. That's what I get for being a git newbie.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants