Proposal for our own HLint rules

[mgajda]

Since style discussions have gathered a lot of attention, I propose to expand the library of our own HLint style hints.

To use: hlint --hint=HLint.hs src/library and enjoy!

I believe there is Emacs mode that can automatically apply hints that you select.

[mgajda]

PS And note that there are many places within the code and commit comments that suggest that the author would like somebody else to participate in cleaning up of this code base... might be nice way of getting familiar with it, just as is extending the keymaps.

[Fuuzetsu]

Looks OK but I'm -1 on fromMaybe warning, fromMaybe sucks for any non-trivial case.

[jhance]

fromMaybe also only works well if there is no complex logic involved in the Nothing case, which isn't necessarily true

[mgajda]

That's why I marked it as just a warning. But in the common case that it is a constant, I would define a constant for the default argument a.