fix: restrict flashmint #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
reviewed
Oct 14, 2020
There was a problem hiding this comment.
The previous fix was not sufficient, as it'd mean that anyone could create a pool contract with a FYDai method and bypass the restriction. I've tightened the limitations here by requiring that the pool provided must be one of the known pools. I had to do it with a function instead of requiring manually each time to keep the bytecode size down.
aniemerg
approved these changes
Oct 14, 2020
gakonst
force-pushed
the
fix/restrict-flashmint
branch
from
d03f74b
to
acbf408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any random user can call executeOnFlashMint, with potential impact to any users that executed vat.hope towards the proxy.
To avoid that,
executeOnFlashMintchecks that it is being called by thefyDaicontract used in the flash mint, which is also thefyDaiseries used for the migration.Fixes #361.