-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable interest rate oracle #543
Merged
iamsahu
merged 8 commits into
feature/variable-rate
from
feat/variable-interest-rate-oracle
Mar 28, 2023
Merged
Variable interest rate oracle #543
iamsahu
merged 8 commits into
feature/variable-rate
from
feat/variable-interest-rate-oracle
Mar 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsahu
force-pushed
the
feat/variable-interest-rate-oracle
branch
from
March 23, 2023 13:06
5302c1f
to
f872ebc
Compare
alcueca
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the bit about input parameters being fp6, but then stored as fp18, and then merge.
iamsahu
added a commit
that referenced
this pull request
Apr 2, 2023
* feat: first commit * fix: pour fix * feat: audit prep * chore: more updates * fix: table corrected * chore: cleanup * chore: clean-up * feat: refactored `joinEther` & `exitEther` * Feat/upgradable contracts (#542) * forge install: openzeppelin-contracts v4.8.2 * feat: UUPS Upgradable Cauldron, Ladle and VYToken * test: VYToken upgrades * feat: create proxies (but don't use them) * feat: set proxies on fixtures and unit test * no idea what happened there * fix: forgot to set the flash fee factor * fix: lock the implementation contracts * feat: Make Witch UUPS upgradable --------- Co-authored-by: alcueca <alberto@yield.is> Co-authored-by: iamsahu <46891804+iamsahu@users.noreply.github.com> * fix: fixed the fixture config * Variable interest rate oracle (#543) * feat: first commit * feat: added calculation for debt across * feat: added mock * feat: join update from ladle * feat: updated to use `IVRCauldron` * feat: updated tests * feat: integrated feedback changes --------- Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com> Co-authored-by: alcueca <alberto@yield.is>
iamsahu
added a commit
that referenced
this pull request
Apr 2, 2023
* feat: first commit * fix: pour fix * feat: audit prep * chore: more updates * fix: table corrected * chore: cleanup * chore: clean-up * feat: refactored `joinEther` & `exitEther` * Feat/upgradable contracts (#542) * forge install: openzeppelin-contracts v4.8.2 * feat: UUPS Upgradable Cauldron, Ladle and VYToken * test: VYToken upgrades * feat: create proxies (but don't use them) * feat: set proxies on fixtures and unit test * no idea what happened there * fix: forgot to set the flash fee factor * fix: lock the implementation contracts * feat: Make Witch UUPS upgradable --------- Co-authored-by: alcueca <alberto@yield.is> Co-authored-by: iamsahu <46891804+iamsahu@users.noreply.github.com> * fix: fixed the fixture config * Variable interest rate oracle (#543) * feat: first commit * feat: added calculation for debt across * feat: added mock * feat: join update from ladle * feat: updated to use `IVRCauldron` * feat: updated tests * feat: integrated feedback changes * feat: How to hack doc added --------- Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com> Co-authored-by: alcueca <alberto@yield.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.