Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable interest rate oracle #543

Merged
merged 8 commits into from
Mar 28, 2023

Conversation

iamsahu
Copy link
Contributor

@iamsahu iamsahu commented Mar 21, 2023

No description provided.

@iamsahu iamsahu requested a review from alcueca March 23, 2023 11:26
@iamsahu iamsahu force-pushed the feat/variable-interest-rate-oracle branch from 5302c1f to f872ebc Compare March 23, 2023 13:06
Copy link
Contributor

@alcueca alcueca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the bit about input parameters being fp6, but then stored as fp18, and then merge.

src/oracles/VariableInterestRateOracle.sol Outdated Show resolved Hide resolved
@iamsahu iamsahu merged commit 709fb12 into feature/variable-rate Mar 28, 2023
iamsahu added a commit that referenced this pull request Apr 2, 2023
* feat: first commit

* fix: pour fix

* feat: audit prep

* chore: more updates

* fix: table corrected

* chore: cleanup

* chore: clean-up

* feat: refactored `joinEther` & `exitEther`

* Feat/upgradable contracts (#542)

* forge install: openzeppelin-contracts

v4.8.2

* feat: UUPS Upgradable Cauldron, Ladle and VYToken

* test: VYToken upgrades

* feat: create proxies (but don't use them)

* feat: set proxies on fixtures and unit test

* no idea what happened there

* fix: forgot to set the flash fee factor

* fix: lock the implementation contracts

* feat: Make Witch UUPS upgradable

---------

Co-authored-by: alcueca <alberto@yield.is>
Co-authored-by: iamsahu <46891804+iamsahu@users.noreply.github.com>

* fix: fixed the fixture config

* Variable interest rate oracle (#543)

* feat: first commit

* feat: added calculation for debt across

* feat: added mock

* feat: join update from ladle

* feat: updated to use `IVRCauldron`

* feat: updated tests

* feat: integrated feedback changes

---------

Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com>
Co-authored-by: alcueca <alberto@yield.is>
iamsahu added a commit that referenced this pull request Apr 2, 2023
* feat: first commit

* fix: pour fix

* feat: audit prep

* chore: more updates

* fix: table corrected

* chore: cleanup

* chore: clean-up

* feat: refactored `joinEther` & `exitEther`

* Feat/upgradable contracts (#542)

* forge install: openzeppelin-contracts

v4.8.2

* feat: UUPS Upgradable Cauldron, Ladle and VYToken

* test: VYToken upgrades

* feat: create proxies (but don't use them)

* feat: set proxies on fixtures and unit test

* no idea what happened there

* fix: forgot to set the flash fee factor

* fix: lock the implementation contracts

* feat: Make Witch UUPS upgradable

---------

Co-authored-by: alcueca <alberto@yield.is>
Co-authored-by: iamsahu <46891804+iamsahu@users.noreply.github.com>

* fix: fixed the fixture config

* Variable interest rate oracle (#543)

* feat: first commit

* feat: added calculation for debt across

* feat: added mock

* feat: join update from ladle

* feat: updated to use `IVRCauldron`

* feat: updated tests

* feat: integrated feedback changes

* feat: How to hack doc added

---------

Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com>
Co-authored-by: alcueca <alberto@yield.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants