-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images are not loading when pulling them in from firebase firestore #1
Comments
Hi @Lewis-Seekio ! Thank you for bringing this issue up! 😄 I replicated the issue you are having locally. I then found that there is something wrong in the code, in line 5 of I edited that file and tried locally and the issue is gone on my machine. I will get this issue fixed and publish a new version before this coming weekend. 👨🏻💻 I will notify you for the new version. |
Awesome! love the carousel btw, really great work. 多谢! |
Thank you for your appreciation! 不用谢!😊 |
Hi @Lewis-Seekio! I fixed this issue and published a new version. Please install this new version by |
Hi @yifaneye, thanks for the reply! I have updated, Unfortunately it still isn't working :( the same problem persists. |
My package.json:
|
Hi @Lewis-Seekio ! Thank you for trying the patch version! I am sorry to hear it still does not work for you! I made an example (example 3) at https://github.com/yifaneye/react-gallery-carousel/blob/master/example/src/App.js . Please try |
@yifaneye It works perfectly now! awesome! 谢谢你的帮助! |
Hi there, this probably isnt a problem with the repo, more me not understanding how to do this properly.
Here is where I pull in the product from firebase:
And then I assign the photos from the product data to "images" and follow the object pattern that the carousel requires:
And then in my jsx:
When the page loads, I can see that the images are in the carousel object, however it doesnt render them, so I'm guessing its rendering the carousel before it has the images ready? Im new to react so can anyone give me some guidance how to make it wait until the images are ready? Thanks!
The text was updated successfully, but these errors were encountered: