Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for tls extension 18(signed_certificate_timestamp) #68

Closed

Conversation

raphaelts3
Copy link

Hello there,

I'm playing with some obscure tls fingerprint and I've manage to mimic almost 100% of it with the current available flags, but for whatever reason, it doesn't contains extension 18 on it from the original source and I want to mimic that behavior, therefore I've made some changes in the patches allowing that to be also switched on/off(default on for the cases where it was already present).

Comment on lines +3144 to +3146
+ if(data->set.ssl_enable_signed_certificate_timestamp) {
+ SSL_CTX_enable_signed_cert_timestamps(backend->ctx);
+ }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else was made so I could have this, btw since the comment says that Firefox does not enable this, I believe it would also be fixed, since I've follow the same defaults as tls_session_ticket and it turns out to be false for non-chrome.

@yifeikong
Copy link
Owner

Thanks for the proposal! I'm open to merge this PR. However, generally, the patches should be exported from the yifeikong/curl repository, where we have upgraded to curl 8.7.1, see also in #67.

Could you please fork yifeikong/curl and open a PR there, so we can land this change based on curl 8.7.1.

@yifeikong
Copy link
Owner

yifeikong commented May 14, 2024

Another approach is to provide the CURLOPT_TLS_EXTENSION_ORDER string. If you want to omit extension 18, simply delete it from the string.

@raphaelts3
Copy link
Author

Closing this in favor of yifeikong/curl#4

@raphaelts3 raphaelts3 closed this May 15, 2024
@raphaelts3 raphaelts3 deleted the add-flag-for-tls-extension-18 branch May 15, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants