Add flag for tls extension 18(signed_certificate_timestamp) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifeikong
reviewed
May 15, 2024
yifeikong
reviewed
May 15, 2024
yifeikong
reviewed
May 15, 2024
|
@yifeikong sorted things out and change the term to be more consistent, I appreciate the quick review 🙇 |
|
Implemented as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close yifeikong/curl-impersonate#68
Hey @yifeikong I did try to use the extension order, but didn't work so well, so I decide to port it to here, as you also suggested, it was mostly manually applying the patches here, so I hope it's going to be fine.
If I understood wrong the way of doing it, please let me know and I will do it in the proper way.