Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR links in PR count #4

Merged
merged 3 commits into from
Dec 31, 2020
Merged

Add PR links in PR count #4

merged 3 commits into from
Dec 31, 2020

Conversation

Allianzcortex
Copy link
Contributor

@Allianzcortex Allianzcortex commented Dec 30, 2020

This will be how it looks :

https://github.com/Allianzcortex/github-readme-stats#the-repos-i-contributed-to

Now users can see the PR links when clicking the PR count.


I will refactor the *.yml part later. Just hope the coding part(github.go) is good to take a look @yihong0618

@yihong0618
Copy link
Owner

cool,can you only change the github.go file~

@Allianzcortex
Copy link
Contributor Author

Allianzcortex commented Dec 30, 2020

@yihong0618 sure thing ! I keep the readme file changed so you can see how it will look after the change. Would u mind reviewing the changes to github.go ? then after that, I will reverse my changes of other parts ( :

@yihong0618
Copy link
Owner

@yihong0618 sure thing ! I keep the readme file changed so you can see how it will look after the change. Would u mind reviewing the changes to github.go ? then after that, I will reverse my changes of other parts ( :

That part looks great, I like that change

@@ -15,7 +15,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: My GitHub Status
uses: yihong0618/my_github@v1
uses: ./
Copy link
Contributor Author

@Allianzcortex Allianzcortex Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why I choose to change it : https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/creating-a-docker-container-action#example-using-a-private-action .

So it will be easier for developers and no influence for users for its already published. Also I'd like to know @frostming 's ideas about this change. I can see related commits here : https://github.com/yihong0618/github-readme-stats/pull/2/files#diff-a3ddd7238fc6e36daeb0ef76e93fe15cc87824bd3299888075210c5ca6a474d3R23

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine, we can keep it using . for this repository

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will use ./, you are right.

@Allianzcortex
Copy link
Contributor Author

@yihong0618 It should be good for another look ^

@yihong0618
Copy link
Owner

Thanks, will take a look and merge this afternoon (timezone +8)

@yihong0618 yihong0618 merged commit 76a0ab9 into yihong0618:main Dec 31, 2020
@yihong0618
Copy link
Owner

@Allianzcortex @frostming
Done and please use github-readme-stats@v1.1

@Allianzcortex
Copy link
Contributor Author

@Allianzcortex @frostming
Done and please use github-readme-stats@v1.1

awwwwwwwww !

@yihong0618
Copy link
Owner

Thank you very much for your pr~

@rtkwlf-hzzz
Copy link

a very weired issue : https://github.com/Allianzcortex/2021/runs/6113317128?check_suite_focus=true . no idea why it suddenly failed even after I tried to re-run many times.

would you mind taking a look when you have time ? @yihong0618

@rtkwlf-hzzz
Copy link

image

i don't think there is any breaking changes/upgrades recently but it can't work..

@yihong0618
Copy link
Owner

the code is updated you can try the latest code. because of git change some logic

@yihong0618
Copy link
Owner

will take a look later. Can you open another issue?

@Allianzcortex
Copy link
Contributor Author

Thanks ! Initially I just update a new action version Allianzcortex/2021@dd554fb and it doesn't work. But it gets fixed after I copy the whole new yml file Allianzcortex/2021@81ab035

@Allianzcortex
Copy link
Contributor Author

I feel no need for a new issue since most users just use the new checkout version. thanks for all the help ^^

@yihong0618
Copy link
Owner

cool just enjoy it😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants