-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PR links in PR count #4
Conversation
cool,can you only change the github.go file~ |
@yihong0618 sure thing ! I keep the readme file changed so you can see how it will look after the change. Would u mind reviewing the changes to |
That part looks great, I like that change |
01bc596
to
2953492
Compare
@@ -15,7 +15,7 @@ jobs: | |||
steps: | |||
- uses: actions/checkout@v2 | |||
- name: My GitHub Status | |||
uses: yihong0618/my_github@v1 | |||
uses: ./ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why I choose to change it : https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/creating-a-docker-container-action#example-using-a-private-action .
So it will be easier for developers and no influence for users for its already published. Also I'd like to know @frostming 's ideas about this change. I can see related commits here : https://github.com/yihong0618/github-readme-stats/pull/2/files#diff-a3ddd7238fc6e36daeb0ef76e93fe15cc87824bd3299888075210c5ca6a474d3R23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine, we can keep it using .
for this repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will use ./, you are right.
@yihong0618 It should be good for another look ^ |
Thanks, will take a look and merge this afternoon (timezone +8) |
@Allianzcortex @frostming |
awwwwwwwww ! |
Thank you very much for your pr~ |
a very weired issue : https://github.com/Allianzcortex/2021/runs/6113317128?check_suite_focus=true . no idea why it suddenly failed even after I tried to re-run many times. would you mind taking a look when you have time ? @yihong0618 |
the code is updated you can try the latest code. because of git change some logic |
will take a look later. Can you open another issue? |
Thanks ! Initially I just update a new |
I feel no need for a new issue since most users just use the new checkout version. thanks for all the help ^^ |
cool just enjoy it😄 |
This will be how it looks :
https://github.com/Allianzcortex/github-readme-stats#the-repos-i-contributed-to
Now users can see the PR links when clicking the PR count.
I will refactor the *.yml part later. Just hope the coding part(github.go) is good to take a look @yihong0618