New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 unrelated improvements: 1. base_pkgs() can "hang". 2. isFALSE()
is faster and better in base
.
#66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 1, that makes perfect sense! For 2, I wish to remove it, too, but 1) I need to figure out which reverse dependencies will be affected and fix them first (like this); then deprecate this function to notify users for some time instead of suddenly removing it; 2) base::isFALSE()
requires R >= 3.5.0, and currently we are supporting R >= 3.3.0, so it will take some time before I can consider removing isFALSE
from xfun (yes, it has existed before R 3.5.0 was released, and I think base::isFALSE()
makes more sense).
Thanks!
This reverts commit cfbf040. It will go to a separate PR.
For |
Yes, I'm sorry for the extra work you had. |
No worries at all! I really appreciate your contribution! If you make the changes in separate branches, you can then submit a separate PR for each branch. For the Github web interface, you can click on the edit button on the toolbar of a file (open a file on Github and find the pencil button on the right) to suggest changes: Then the web interface will guide you to create a new branch for the changes that you made. I guess that you did was first forking the repo, then making the changes in the |
I found that
knitr::write_bib()
would hang the R process for me. Found then that it was whenxfun::base_pkgs()
was called.The reason is I have 20'000 packages installed in my
.libPaths()
. Instead, the base packages are always in.Library
hence 197e357.I saw your
isFALSE()
. Presumably it is older than the one in{base}
which is also a few years old. When we introduced it (I was involved with it), we found we do not want identical, because aFALSE
(orTRUE
) can also end up withnames
or other such attributes. The change cfbf040 keeps xfun'sisFALSE()
local, i.e, does just not export it. Personally I think you should even not define it anymore, but rather use thebase
one for consistency.