Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 unrelated improvements: 1. base_pkgs() can "hang". 2. isFALSE() is faster and better in base. #66

Merged
merged 4 commits into from May 20, 2022
Merged

2 unrelated improvements: 1. base_pkgs() can "hang". 2. isFALSE() is faster and better in base. #66

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfbf040
base::isFALSE() is better (very slightly different)
mmaechler May 20, 2022
197e357
base_pkgs(): not using large .libPaths(), just .Library !
mmaechler May 20, 2022
889e420
add a news item for #66
yihui May 20, 2022
6f2dd4f
Revert "base::isFALSE() is better (very slightly different)"
yihui May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion NAMESPACE
View file
Open in desktop
Expand Up @@ -49,7 +49,6 @@ export(gsub_files)
export(in_dir)
export(install_dir)
export(install_github)
export(isFALSE)
export(is_CRAN_incoming)
export(is_R_CMD_check)
export(is_abs_path)
Expand Down
2 changes: 1 addition & 1 deletion R/packages.R
View file
Open in desktop
Expand Up @@ -344,7 +344,7 @@ news2md = function(package, ..., output = 'NEWS.md', category = TRUE) {
#' @export
#' @examplesIf interactive()
#' xfun::base_pkgs()
base_pkgs = function() rownames(installed.packages(priority = 'base'))
base_pkgs = function() rownames(installed.packages(.Library, priority = 'base'))

# update one package (from source by default)
pkg_update_one = function(pkg, type = 'source') {
Expand Down
4 changes: 2 additions & 2 deletions R/utils.R
View file
Open in desktop
Expand Up @@ -116,10 +116,10 @@ in_dir = function(dir, expr) {
}

#' Test if an object is identical to \code{FALSE}
#'
#' *NO LONGER* exported: base::isFALSE() is faster and better,
#' when FALSE has an attribute: base::isFALSE(c(a = FALSE)) is TRUE
#' A simple abbreviation of \code{identical(x, FALSE)}.
#' @param x An R object.
#' @export
#' @examples
#' library(xfun)
#' isFALSE(TRUE) # false
Expand Down
20 changes: 0 additions & 20 deletions man/isFALSE.Rd
View file
Open in desktop

This file was deleted.