Skip to content
This repository has been archived by the owner on Jul 6, 2022. It is now read-only.

Feature: not interpret env in compiled files #53

Merged
merged 12 commits into from May 25, 2020
Merged

Feature: not interpret env in compiled files #53

merged 12 commits into from May 25, 2020

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented May 20, 2020

Q A
Bugfix? ✔️
Feature? ✔️
Break compatibility? ❌
Tests pass? ✔️
Fix issues #47

@xepozz xepozz changed the title Feature not interpret env Feature: not interpret env in compiled files May 20, 2020
@xepozz xepozz marked this pull request as draft May 20, 2020 20:25
@xepozz xepozz requested review from hiqsol and a team May 20, 2020 20:29
@xepozz xepozz added the status:code review The pull request needs review. label May 20, 2020
@xepozz xepozz marked this pull request as ready for review May 20, 2020 20:29
roxblnfk
roxblnfk reviewed May 20, 2020
View reviewed changes
src/Util/EnvEncoder.php Show resolved Hide resolved
src/Util/EnvEncoder.php Outdated Show resolved Hide resolved
src/Util/EnvEncoder.php Outdated Show resolved Hide resolved
src/Env.php Outdated Show resolved Hide resolved
@roxblnfk roxblnfk requested a review from a team May 20, 2020 20:47
xepozz and others added 2 commits May 20, 2020 23:48
samdark
samdark reviewed May 23, 2020
View reviewed changes
src/Env.php Outdated Show resolved Hide resolved
tests/Unit/Util/HelperTest.php Outdated Show resolved Hide resolved
@samdark
Copy link
Member

samdark commented May 23, 2020

It doesn't work with expressions such as 'test' => Env::get('test') ?? true. Result is 'test' => $_ENV['test'] without default value.

@samdark samdark added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels May 23, 2020
hiqsol
hiqsol approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@hiqsol hiqsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@samdark samdark added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels May 24, 2020
@samdark
Copy link
Member

samdark commented May 24, 2020

👍 but need docs for this one. @xepozz are you into docs? If not, I can handle it.

@samdark samdark added type:docs Documentation and removed status:code review The pull request needs review. labels May 24, 2020
@xepozz
Copy link
Contributor Author

xepozz commented May 24, 2020

👍 but need docs for this one. @xepozz are you into docs? If not, I can handle it.

No, I don't. Please do it yourself :)

@samdark
Copy link
Member

samdark commented May 25, 2020

Docs will be added separately in #45

@samdark samdark merged commit 975bfb3 into yiisoft:master May 25, 2020
@samdark
Copy link
Member

samdark commented May 25, 2020

👍

@xepozz xepozz deleted the feature-not-interpret-env branch May 25, 2020 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdark samdark samdark left review comments

@roxblnfk roxblnfk roxblnfk left review comments

@hiqsol hiqsol hiqsol approved these changes

Assignees
No one assigned
Labels
type:docs Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xepozz @samdark @roxblnfk @hiqsol