This repository has been archived by the owner on Jul 6, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 15
Feature: not interpret env in compiled files #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xepozz
commented
May 20, 2020
Q | A |
---|---|
Bugfix? | ✔️ |
Feature? | ✔️ |
Break compatibility? | ❌ |
Tests pass? | ✔️ |
Fix issues | #47 |
xepozz
changed the title
Feature not interpret env
Feature: not interpret env in compiled files
May 20, 2020
roxblnfk
reviewed
May 20, 2020
Co-authored-by: roxblnfk <roxblnfk@ya.ru>
samdark
reviewed
May 23, 2020
It doesn't work with expressions such as |
samdark
added
status:under development
Someone is working on a pull request.
and removed
status:code review
The pull request needs review.
labels
May 23, 2020
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
…feature-not-interpret-env
hiqsol
approved these changes
May 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
samdark
added
status:code review
The pull request needs review.
and removed
status:under development
Someone is working on a pull request.
labels
May 24, 2020
👍 but need docs for this one. @xepozz are you into docs? If not, I can handle it. |
samdark
added
type:docs
Documentation
and removed
status:code review
The pull request needs review.
labels
May 24, 2020
No, I don't. Please do it yourself :) |
Docs will be added separately in #45 |
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.