Fix config for added set prefixes to MigrationService setters (#233)

Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
yiisoft · Nov 10, 2023 · ad391f4 · ad391f4
1 parent b0ce83d
commit ad391f4
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 17 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -38,9 +38,9 @@ jobs:
           - ubuntu-latest
 
         php:
-          - 8.0
-          - 8.1
-          - 8.2
+          - '8.0'
+          - '8.1'
+          - '8.2'
 
     steps:
       - name: Checkout.
@@ -61,7 +61,7 @@ jobs:
         run: composer require yiisoft/db-sqlite:^1.0 --prefer-dist --no-interaction --no-progress --optimize-autoloader --ansi
 
       - name: Run tests with phpunit.
-        run: vendor/bin/phpunit --testsuite=YiiDbMigration --coverage-clover=coverage.xml --colors=always
+        run: vendor/bin/phpunit --testsuite=Migration --coverage-clover=coverage.xml --colors=always
 
       - name: Upload coverage to Codecov.
         if: matrix.php == '8.1'

diff --git a/bin/MigrationContainer.php b/bin/MigrationContainer.php
@@ -29,10 +29,10 @@ public static function definitions(): array
             ],
             MigrationService::class => [
                 'class' => MigrationService::class,
-                'createNamespace()' => [''],
-                'createPath()' => [''],
-                'updateNamespaces()' => [[]],
-                'updatePaths()' => [[]],
+                'setCreateNamespace()' => [''],
+                'setCreatePath()' => [''],
+                'setUpdateNamespaces()' => [[]],
+                'setUpdatePaths()' => [[]],
             ],
             Migrator::class => [
                 '__constructor()' => [

diff --git a/config/di-console.php b/config/di-console.php
@@ -11,10 +11,10 @@
 return [
     MigrationService::class => [
         'class' => MigrationService::class,
-        'createNamespace()' => [$params['yiisoft/db-migration']['createNamespace']],
-        'updateNamespaces()' => [$params['yiisoft/db-migration']['updateNamespaces']],
-        'createPath()' => [$params['yiisoft/db-migration']['createPath']],
-        'updatePaths()' => [$params['yiisoft/db-migration']['updatePaths']],
+        'setCreateNamespace()' => [$params['yiisoft/db-migration']['createNamespace']],
+        'setUpdateNamespaces()' => [$params['yiisoft/db-migration']['updateNamespaces']],
+        'setCreatePath()' => [$params['yiisoft/db-migration']['createPath']],
+        'setUpdatePaths()' => [$params['yiisoft/db-migration']['updatePaths']],
     ],
 
     MigrationInformerInterface::class => ConsoleMigrationInformer::class,

diff --git a/docs/en/usage-with-symfony-console.md b/docs/en/usage-with-symfony-console.md
@@ -56,10 +56,10 @@ final class MigrationContainer
             ],
             MigrationService::class => [
                 'class' => MigrationService::class,
-                'createNamespace()' => [''],
-                'createPath()' => [''],
-                'updateNamespaces()' => [['Yii\\User\\Framework\\Migration']],
-                'updatePaths()' => [[]],
+                'serCreateNamespace()' => [''],
+                'setCreatePath()' => [''],
+                'setUpdateNamespaces()' => [['Yii\\User\\Framework\\Migration']],
+                'setUpdatePaths()' => [[]],
             ],
             MigrationInformerInterface::class => ConsoleMigrationInformer::class,
         ];

diff --git a/tests/Migration/ConfigTest.php b/tests/Migration/ConfigTest.php
@@ -45,7 +45,7 @@ public function testBase(): void
         $this->assertInstanceOf(UpdateCommand::class, $container->get(UpdateCommand::class));
 
         // Informer
-        $this->assertInstanceOf(NullMigrationInformer::class, $container->get(MigrationInformerInterface::class));
+        $this->assertInstanceOf(ConsoleMigrationInformer::class, $container->get(MigrationInformerInterface::class));
         $this->assertInstanceOf(NullMigrationInformer::class, $container->get(NullMigrationInformer::class));
         $this->assertInstanceOf(ConsoleMigrationInformer::class, $container->get(ConsoleMigrationInformer::class));