Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config for added set prefixes to MigrationService setters #233

Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 10, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 10, 2023

PR Summary

  • Redefinition of methods in MigrationContainer file
    The bin/MigrationContainer.php file had some method name updates. Methods initially named createNamespace(), createPath(), updateNamespaces(), and updatePaths() have now been renamed to setCreateNamespace(), setCreatePath(), setUpdateNamespaces(), and setUpdatePaths(), respectively.

  • Method name changes in di-console configuration file
    Similar changes were made in the config/di-console.php file where the methods createNamespace(), updateNamespaces(), createPath(), and updatePaths() were updated to setCreateNamespace(), setUpdateNamespaces(), setCreatePath(), and setUpdatePaths(), respectively.

  • Corrections in documentation
    The documentation file docs/en/usage-with-symfony-console.md had some corrections. An error previously referred to these methods as serCreateNamespace(), setCreatePath(), setUpdateNamespaces(), setUpdatePaths() instead of the correct method names which are setCreateNamespace(), setCreatePath(), setUpdateNamespaces(), and setUpdatePaths(). This was corrected in this PR.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0ce83d) 99.80% compared to head (8dd4420) 100.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #233      +/-   ##
=============================================
+ Coverage     99.80%   100.00%   +0.19%     
  Complexity      309       309              
=============================================
  Files            19        19              
  Lines          1014      1014              
=============================================
+ Hits           1012      1014       +2     
+ Misses            2         0       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit ad391f4 into master Nov 10, 2023
79 checks passed
@vjik vjik deleted the fix-config-for-added-set-prefixes-to-MigrationService-setters branch November 10, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants