Fix 11: Remove dead code. (#400)

* Remove dead code.
yiisoft · Dec 1, 2022 · b3707d0 · b3707d0
1 parent fcdf189
commit b3707d0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/src/QueryBuilder/DMLQueryBuilder.php b/src/QueryBuilder/DMLQueryBuilder.php
@@ -216,9 +216,6 @@ protected function prepareInsertValues(string $table, array|QueryInterface $colu
 
                 if ($value instanceof ExpressionInterface) {
                     $placeholders[] = $this->queryBuilder->buildExpression($value, $params);
-                } elseif ($value instanceof QueryInterface) {
-                    [$sql, $params] = $this->queryBuilder->build($value, $params);
-                    $placeholders[] = "($sql)";
                 } else {
                     $placeholders[] = $this->queryBuilder->bindParam($value, $params);
                 }

diff --git a/src/QueryBuilder/DQLQueryBuilder.php b/src/QueryBuilder/DQLQueryBuilder.php
@@ -348,7 +348,7 @@ public function buildSelect(
             return $select . ' *';
         }
 
-        /** @psalm-var array<array-key, ExpressionInterface|Query|string> $columns */
+        /** @psalm-var array<array-key, ExpressionInterface|string> $columns */
         foreach ($columns as $i => $column) {
             if ($column instanceof ExpressionInterface) {
                 if (is_int($i)) {
@@ -357,9 +357,6 @@ public function buildSelect(
                     $columns[$i] = $this->buildExpression($column, $params) . ' AS '
                         . $this->quoter->quoteColumnName($i);
                 }
-            } elseif ($column instanceof QueryInterface) {
-                [$sql, $params] = $this->build($column, $params);
-                $columns[$i] = "($sql) AS " . $this->quoter->quoteColumnName((string) $i);
             } elseif (is_string($i) && $i !== $column) {
                 if (!str_contains($column, '(')) {
                     $column = $this->quoter->quoteColumnName($column);