Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 11: Remove dead code. #400

Merged
merged 3 commits into from Dec 1, 2022
Merged

Fix 11: Remove dead code. #400

merged 3 commits into from Dec 1, 2022

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Nov 30, 2022

  • Removed the support for subqueries in INSERT statements.
  • Fixed a bug where an expression was not quoted when used as column name in SELECT statement.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 94.72% // Head: 94.86% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (1f2e67e) compared to base (fcdf189).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #400      +/-   ##
============================================
+ Coverage     94.72%   94.86%   +0.13%     
+ Complexity     1246     1244       -2     
============================================
  Files            57       57              
  Lines          2711     2705       -6     
============================================
- Hits           2568     2566       -2     
+ Misses          143      139       -4     
Impacted Files Coverage Δ
src/QueryBuilder/DMLQueryBuilder.php 96.18% <ø> (+1.40%) ⬆️
src/QueryBuilder/DQLQueryBuilder.php 94.31% <ø> (+0.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Nov 30, 2022
@terabytesoftw terabytesoftw marked this pull request as ready for review November 30, 2022 09:29
@terabytesoftw terabytesoftw merged commit b3707d0 into master Dec 1, 2022
@terabytesoftw terabytesoftw deleted the remove-dead-code branch December 1, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants